Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid compute stake distribution multiple times per epoch #805

Merged
merged 3 commits into from
Mar 15, 2023
Merged

Avoid compute stake distribution multiple times per epoch #805

merged 3 commits into from
Mar 15, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Mar 15, 2023 •
edited
Loading

Content

This PR includes a fix that avoids the computation of the stake distribution multiple times per epoch.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Useful pull request description
    • Self-reviewed the diff
    • Reviewer requested

Issue(s)

Closes #804

@jpraynaud
Fix Stake Distribution signer
655bac9 
Avoid recomputing the stake distribution multiple times per epoch.
@jpraynaud jpraynaud force-pushed the jpraynaud/804-fix-stake-distribution-compute-optimization branch from 60ca2ae to f3f6da7 Compare March 15, 2023 10:07
@jpraynaud jpraynaud self-assigned this Mar 15, 2023
@jpraynaud
Fix Stake Distribution aggregator
a6a8576 
Avoid recomputing the stake distribution multiple times per epoch.
@github-actions
Copy link

github-actions bot commented Mar 15, 2023 •
edited
Loading

Test Results

    3 files  ±0    30 suites  ±0   5m 47s ⏱️ -4s
472 tests ±0  472 ✔️ +1  0 💤 ±0  0 ❌  - 1 
542 runs  ±0  542 ✔️ +1  0 💤 ±0  0 ❌  - 1 

Results for commit 53c0a00. ± Comparison against base commit 459d644.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-preview March 15, 2023 10:15 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/804-fix-stake-distribution-compute-optimization branch from f3f6da7 to 53c0a00 Compare March 15, 2023 10:16
@jpraynaud jpraynaud requested a review from ghubertpalo March 15, 2023 10:16
@jpraynaud jpraynaud temporarily deployed to testing-preview March 15, 2023 10:26 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit f8dbd4e into main Mar 15, 2023
@jpraynaud jpraynaud deleted the jpraynaud/804-fix-stake-distribution-compute-optimization branch March 15, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghubertpalo ghubertpalo ghubertpalo approved these changes

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Stake Distribution done multiple times per epoch
2 participants
@jpraynaud @ghubertpalo